On Thu, Dec 13, 2018 at 10:54:28PM +0200, sakari.ailus@xxxxxx wrote: > Hi Maxime, > > One more small note. > > On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > > ... > > > + /** > > + * @wakeup: > > + * > > + * Time, in picoseconds, that a transmitter drives a Mark-1 > > + * state prior to a Stop state in order to initiate an exit > > + * from ULPS. > > + * > > + * Minimum value: 1000000000 ps > > + */ > > + unsigned int wakeup; > > This is very close to the higher limit of the type's value range. How about > using ns or µs for this one? Same for init actually. -- Sakari Ailus