Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/12/2018 08:07 AM, Alexandre Courbot wrote:
> Hi Hans,
> 
> On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>>
>> As was discussed here (among other places):
>>
>> https://lkml.org/lkml/2018/10/19/440
>>
>> using capture queue buffer indices to refer to reference frames is
>> not a good idea. A better idea is to use 'cookies' (a better name is
>> welcome!)
> 
> Maybe "tag" is more common for that kind of usage, but "cookie" is
> fine as well IMHO.

'tag' is MUCH better than cookie. I'll rename and thank you for this
excellent suggestion. That's really what we do: tagging buffers.

Regards,

	Hans

> 
> I can only comment on patches 1-4, but so far it seems to me that this
> would work. I will use this to base the next stateless codec API RFC.
> 
> Thanks!
> Alex.
> 




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux