On Wed, Oct 31, 2018 at 06:40:30AM -0300, Mauro Carvalho Chehab wrote: > Em Wed, 31 Oct 2018 11:29:45 +0200 > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu: > > > Hi Mauro, > > > > On Tue, Oct 30, 2018 at 09:06:18AM -0300, Mauro Carvalho Chehab wrote: > > > Em Tue, 30 Oct 2018 01:00:29 +0200 > > > Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> escreveu: > > > > > > > Clean up the SoC camera framework header. It only exists now to keep board > > > > code compiling. The header can be removed once the board code dependencies > > > > to it has been removed. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > > --- > > > > include/media/soc_camera.h | 335 --------------------------------------------- > > > > 1 file changed, 335 deletions(-) > > > > > > > > diff --git a/include/media/soc_camera.h b/include/media/soc_camera.h > > > > index b7e42a1b0910..14d19da6052a 100644 > > > > --- a/include/media/soc_camera.h > > > > +++ b/include/media/soc_camera.h > > > > @@ -22,172 +22,6 @@ > > > > #include <media/v4l2-ctrls.h> > > > > #include <media/v4l2-device.h> > > > > > > That doesn't make any sense. soc_camera.h should have the same fate > > > as the entire soc_camera infrastructure: either be removed or moved > > > to staging, and everything else that doesn't have the same fate > > > should get rid of this header. > > > > We can't just remove this; there is board code that depends on it. > > > > The intent is to remove the board code as well but presuming that the board > > code would be merged through a different tree, it'd be less hassle to wait > > a bit; hence the patch removing any unnecessary stuff here. > > Then we need *first* to remove board code, wait for those changes to be > applied and *then* remove soc_camera (and not the opposite). Any reasoning behind that? It's dead code and there is no dependency between the SoC camera framework (apart from the header) and the board code. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
