Hi Sean,
On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote:
> The generic pwm-ir-tx driver should work for the Nokia n900.
>
> Compile tested only.
>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@xxxxxxxxx>
> Cc: Pali Rohár <pali.rohar@xxxxxxxxx>
> Cc: Pavel Machek <pavel@xxxxxx>
> Cc: Timo Kokkonen <timo.t.kokkonen@xxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> Signed-off-by: Sean Young <sean@xxxxxxxx>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 2 +-
> drivers/media/rc/pwm-ir-tx.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 182a53991c90..fd12dea15799 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -154,7 +154,7 @@
> };
>
> ir: n900-ir {
> - compatible = "nokia,n900-ir";
> + compatible = "nokia,n900-ir", "pwm-ir-tx";
> pwms = <&pwm9 0 26316 0>; /* 38000 Hz */
> };
>
> diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
> index 27d0f5837a76..272947b430c8 100644
> --- a/drivers/media/rc/pwm-ir-tx.c
> +++ b/drivers/media/rc/pwm-ir-tx.c
> @@ -30,6 +30,7 @@ struct pwm_ir {
> };
>
> static const struct of_device_id pwm_ir_of_match[] = {
> + { .compatible = "nokia,n900-ir" },
Is this change needed as well? I suppose you could add it later if there's
a need to e.g. do something differently for the N900 IR transmitter.
It'd be nice if someone tested it, too...
> { .compatible = "pwm-ir-tx", },
> { },
> };
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx
