On Tue, Jul 10, 2018 at 07:37:54AM +0000, Yeh, Andy wrote:
> Hi PC,
>
> Thanks for the patch.
>
> Cc in Grant, and Intel Jim/Jason
>
> > -----Original Message-----
> > From: Chen, Ping-chung
> > Sent: Tuesday, July 10, 2018 3:16 PM
> > To: linux-media@xxxxxxxxxxxxxxx
> > Cc: sakari.ailus@xxxxxxxxxxxxxxx; Yeh, Andy <andy.yeh@xxxxxxxxx>;
> > tfiga@xxxxxxxxxxxx; Chen, Ping-chung <ping-chung.chen@xxxxxxxxx>
> > Subject: [PATCH] media: imx208: Add imx208 camera sensor driver
> > +};
> > +
> > +static int imx208_enum_mbus_code(struct v4l2_subdev *sd,
> > + struct v4l2_subdev_pad_config *cfg,
> > + struct v4l2_subdev_mbus_code_enum *code) {
> > + /* Only one bayer order(GRBG) is supported */
> > + if (code->index > 0)
> > + return -EINVAL;
> > +
>
> There is no limitation on using GRBG bayer order now. You can refer to imx355 driver as well.
It seems the rest of the driver uses RGGB.
The enumeration should only contain what is possible using the current
flipping configuration.
--
Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
