Hi Hans, On Monday, 9 July 2018 16:42:09 EEST Hans Verkuil wrote: > On 09/07/18 15:00, Laurent Pinchart wrote: > > On Friday, 29 June 2018 20:40:49 EEST Ezequiel Garcia wrote: > >> On 29 June 2018 at 08:43, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > >>> From: Hans Verkuil <hansverk@xxxxxxxxx> > >>> > >>> The use of 'DTV' is very confusing since it normally refers to Digital > >>> TV e.g. DVB etc. > >>> > >>> Instead use 'DV' (Digital Video), which nicely corresponds to the > >>> DV Timings API used to configure such receivers and transmitters. > >>> > >>> We keep an alias to avoid breaking userspace applications. > >>> > >>> Signed-off-by: Hans Verkuil <hansverk@xxxxxxxxx> > >>> --- > >>> > >>> Documentation/media/uapi/mediactl/media-types.rst | 2 +- > >>> drivers/media/i2c/adv7604.c | 1 + > >>> drivers/media/i2c/adv7842.c | 1 + > >> > >> It would be nice to mention in the commit log > >> that this patch also sets the function for these drivers. > > > > That's also my only concern with this patch (alternatively that change > > could be split to a separate patch). > > I'll clarify the commit log. I can't split up this patch since the old > define is only available under #ifndef __KERNEL__, to prevent drivers from > accidentally using it in the kernel in the future. But the two drivers above don't use MEDIA_ENT_F_DTV_DECODER, do they ? Only drivers/media/i2c/tda1997x.c does. -- Regards, Laurent Pinchart
