Re: [PATCHv5 05/12] media: rename MEDIA_ENT_F_DTV_DECODER to MEDIA_ENT_F_DV_DECODER

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Friday, 29 June 2018 20:40:49 EEST Ezequiel Garcia wrote:
> On 29 June 2018 at 08:43, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> > From: Hans Verkuil <hansverk@xxxxxxxxx>
> > 
> > The use of 'DTV' is very confusing since it normally refers to Digital
> > TV e.g. DVB etc.
> > 
> > Instead use 'DV' (Digital Video), which nicely corresponds to the
> > DV Timings API used to configure such receivers and transmitters.
> > 
> > We keep an alias to avoid breaking userspace applications.
> > 
> > Signed-off-by: Hans Verkuil <hansverk@xxxxxxxxx>
> > ---
> > 
> >  Documentation/media/uapi/mediactl/media-types.rst | 2 +-
> >  drivers/media/i2c/adv7604.c                       | 1 +
> >  drivers/media/i2c/adv7842.c                       | 1 +
> 
> It would be nice to mention in the commit log
> that this patch also sets the function for these drivers.

That's also my only concern with this patch (alternatively that change could 
be split to a separate patch).

-- 
Regards,

Laurent Pinchart






[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux