Hi Jacopo, Thanks for your work. On 2018-05-29 17:05:56 +0200, Jacopo Mondi wrote: > Handle data-enable signal polarity. If the polarity is not specifically > requested to be active low, use the active high default. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Acked-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > v3: > - use new property to set the CES bit > --- > drivers/media/platform/rcar-vin/rcar-dma.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c > index d2b7002..9145b56 100644 > --- a/drivers/media/platform/rcar-vin/rcar-dma.c > +++ b/drivers/media/platform/rcar-vin/rcar-dma.c > @@ -123,6 +123,7 @@ > /* Video n Data Mode Register 2 bits */ > #define VNDMR2_VPS (1 << 30) > #define VNDMR2_HPS (1 << 29) > +#define VNDMR2_CES (1 << 28) > #define VNDMR2_FTEV (1 << 17) > #define VNDMR2_VLV(n) ((n & 0xf) << 12) > > @@ -698,6 +699,10 @@ static int rvin_setup(struct rvin_dev *vin) > /* Vsync Signal Polarity Select */ > if (!(vin->parallel->mbus_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)) > dmr2 |= VNDMR2_VPS; > + > + /* Data Enable Polarity Select */ > + if (vin->parallel->mbus_flags & V4L2_MBUS_DATA_ENABLE_LOW) > + dmr2 |= VNDMR2_CES; > } > > /* > -- > 2.7.4 > -- Regards, Niklas Söderlund
