RE: [PATCH - v0 2/2] DaVinci - vpfe capture - Make clocks configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vaibhav,

I have posted a re-worked patch with clocks configuration moved
to ccdc. From your response below, I understand the clocks
are being called differently on different SoCs even though they
use the same IP. So IMO, it is better to customize it on a SoC 
by defining the clock names in the respective platform file as
done by my original patch. This will avoid confusion since we need to
keep the name in sync with hardware signal names.

-Murali
>[Hiremath, Vaibhav] Murali,
>
>They might be using different naming conventions but the number of clocks
>will always remain the same. If not, then they are not same IP and most
>probably will not use same driver.
>
>Just to clarify more on your Q, AM3517 also uses 2 clocks
>
>- vpfe_ck (functional clock)
>- vpfe_pck (external clock, pixel clock)
>

>Whereas you are referring them as master and slave clock.
>
>Thanks,
>Vaibhav
>
>
>> Murali
>> >Thanks,
>> >Vaibhav
>> >
>> >>  };
>> >>
>> >>  static struct platform_device *davinci_evm_devices[] __initdata
>> = {
>> >> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c
>> >> b/arch/arm/mach-davinci/board-dm644x-evm.c
>> >> index fd0398b..45beb99 100644
>> >> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
>> >> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
>> >> @@ -250,6 +250,8 @@ static struct vpfe_config vpfe_cfg = {
>> >>  	.sub_devs = vpfe_sub_devs,
>> >>  	.card_name = "DM6446 EVM",
>> >>  	.ccdc = "DM6446 CCDC",
>> >> +	.num_clocks = 2,
>> >> +	.clocks = {"vpss_master", "vpss_slave"},
>> >>  };
>> >>
>> >>  static struct platform_device rtc_dev = {
>> >> --
>> >> 1.6.0.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-
>> media" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux