> -----Original Message-----
> From: Karicheri, Muralidharan
> Sent: Tuesday, December 01, 2009 10:49 PM
> To: linux-media@xxxxxxxxxxxxxxx; hverkuil@xxxxxxxxx;
> khilman@xxxxxxxxxxxxxxxxxxx
> Cc: davinci-linux-open-source@xxxxxxxxxxxxxxxxxxxx; Hiremath,
> Vaibhav; Karicheri, Muralidharan
> Subject: [PATCH - v0 2/2] DaVinci - vpfe capture - Make clocks
> configurable
>
> From: Muralidharan Karicheri <m-karicheri2@xxxxxx>
>
> Adding the clocks in vpfe capture configuration
>
> Signed-off-by: Muralidharan Karicheri <m-karicheri2@xxxxxx>
> ---
> arch/arm/mach-davinci/board-dm355-evm.c | 2 ++
> arch/arm/mach-davinci/board-dm644x-evm.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c
> b/arch/arm/mach-davinci/board-dm355-evm.c
> index a9b650d..a28985c 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -239,6 +239,8 @@ static struct vpfe_config vpfe_cfg = {
> .sub_devs = vpfe_sub_devs,
> .card_name = "DM355 EVM",
> .ccdc = "DM355 CCDC",
> + .num_clocks = 2,
> + .clocks = {"vpss_master", "vpss_slave"},
[Hiremath, Vaibhav] Hi Murali,
I was talking to Sekhar about this and actually he made some good points about this implementation.
If we consider specific IP, then the required clocks would remain always be the same. There might be some devices which may not be using some clocks (so as that specific feature).
Actually we are trying to create one more wrapper for clock configuration. Just to illustrate I am putting some other generic drivers examples -
Omap-hsmmc.c -
This driver requires 2 clocks, interface and functional. The devices which would be using this driver have to define clock with names "ick" and "fck".
VPFE-Capture (Considering only current implementation) -
Currently we have vpfe_capture.c file (master/bridge driver) which is handling clk_get/put, and platform data is providing the details about it.
Ideally we should handle it in respective ccdc driver file, since he has all the knowledge about required number of clocks and its name. This way we don't have to maintain/pass clock information in platform data.
I would appreciate any comments/thoughts/pointers here.
Thanks,
Vaibhav
> };
>
> static struct platform_device *davinci_evm_devices[] __initdata = {
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c
> b/arch/arm/mach-davinci/board-dm644x-evm.c
> index fd0398b..45beb99 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -250,6 +250,8 @@ static struct vpfe_config vpfe_cfg = {
> .sub_devs = vpfe_sub_devs,
> .card_name = "DM6446 EVM",
> .ccdc = "DM6446 CCDC",
> + .num_clocks = 2,
> + .clocks = {"vpss_master", "vpss_slave"},
> };
>
> static struct platform_device rtc_dev = {
> --
> 1.6.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
