On 08/05/18 12:49, Mauro Carvalho Chehab wrote:
> Em Tue, 8 May 2018 10:07:22 +0200
> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
>
>>>> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
>>>> index 76352eb59f14..a0f7c38d1a90 100644
>>>> --- a/include/media/v4l2-ctrls.h
>>>> +++ b/include/media/v4l2-ctrls.h
>>>> @@ -250,6 +250,10 @@ struct v4l2_ctrl {
>>>> * ``prepare_ext_ctrls`` function at ``v4l2-ctrl.c``.
>>>> * @from_other_dev: If true, then @ctrl was defined in another
>>>> * device than the &struct v4l2_ctrl_handler.
>>>> + * @done: If true, then this control reference is part of a
>>>> + * control cluster that was already set while applying
>>>> + * the controls in this media request object.
>>>
>>> Hmm... I would rename it for request_done or something similar, as it
>>> seems that this applies only for requests.
>>
>> No, the variable name is correct (it serves the same purpose as the 'done'
>> field in struct v4l2_ctrl), but the description should be improved.
>>
>> I also want to take another look at this: I wonder if it isn't possible to
>> use the v4l2_ctrl 'done' field for this instead of having to add a new field
>> here.
Unfortunately, that isn't possible.
>
> If it can use v4l2_ctrl done, it would indeed be better. Otherwise, as
> this new "done" is used only by requests, I really think that it shold
> be renamed, to let it clearer that this is the "done" that should be used
> when requests are used.
I've renamed 'done' to req_done and improved (I hope) the comment.
Regards,
Hans
>
> Thanks,
> Mauro
>
