On Wed, May 23, 2018 at 11:37:47AM +0300, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday, 23 May 2018 11:33:26 EEST Simon Horman wrote: > > On Tue, May 22, 2018 at 01:04:56PM +0200, Geert Uytterhoeven wrote: > > > On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > > >>> --- a/drivers/media/platform/vsp1/vsp1_regs.h > > >>> +++ b/drivers/media/platform/vsp1/vsp1_regs.h > > >>> @@ -1,4 +1,4 @@ > > >>> -/* SPDX-License-Identifier: GPL-2.0 */ > > >>> +/* SPDX-License-Identifier: GPL-2.0+ */ > > >> > > >> While you are changing this line, I believe the correct format is > > >> to use a '//' comment. > > >> > > >> i.e.: > > >> > > >> // SPDX-License-Identifier: GPL-2.0+ > > > > > > Not for C header files, only for C source files. > > > > Wow! > > Yes, it's a mess :-( The rationale is that the assembler doesn't support C++- > style comments, so we need to use C-style comments in header files. We should > really have standardized usage of C-style comments everywhere, it makes no > sense to me. I'm reading this email while standing on my head and things make much more sense :)
