Hi Simon, On Tue, May 22, 2018 at 11:05 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: >> --- a/drivers/media/platform/vsp1/vsp1_regs.h >> +++ b/drivers/media/platform/vsp1/vsp1_regs.h >> @@ -1,4 +1,4 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +/* SPDX-License-Identifier: GPL-2.0+ */ > > While you are changing this line, I believe the correct format is > to use a '//' comment. > > i.e.: > > // SPDX-License-Identifier: GPL-2.0+ Not for C header files, only for C source files. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds