Hi Philipp, Jan,
On 05/08/2018 07:25 AM, Philipp Zabel wrote:
On Tue, 2018-05-08 at 16:14 +0200, Jan Luebbe wrote:
The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic
mode on the parallel bus, compared to a specific mode on MIPI CSI-2.
To handle this, we extend imx_media_pixfmt with a cycles per pixel
field, which is used for generic formats on the parallel bus.
Before actually adding RGB565_2X8 support for the parallel bus, this
series simplifies handing of the the different configurations for RGB565
between parallel and MIPI CSI-2 in imx-media-capture. This avoids having
to explicitly pass on the format in the second patch.
Changes since v1:
- fixed problems reported the kbuild test robot
- added helper functions as suggested by Steve Longerbeam
(is_parallel_bus and requires_passthrough)
- removed passthough format check in csi_link_validate() (suggested by
Philipp Zabel during internal review)
The theory is that IC only supports AYUV8_1X32 and RGB888_1X24 input,
and any passthrough format on the CSI sink will differ from those.
Mismatching formats are already caught by v4l2_subdev_link_validate
called on the ipu?_vdic or ipu?_ic_prp entities' sink pads.
Right, the CSI will pass parallel-bus RGB565_2X8 through to the source
pad. If the CSI is then linked to ->IC_PRP or ->VDIC,
v4l2_subdev_link_validate
will catch the mbus format mismatch. So the check in csi_link_validate
is not really necessary, thanks for catching.
Steve
