On Tue, Apr 24, 2018 at 02:03:22PM +0200, Daniel Mack wrote: > Hi, > > On Tuesday, April 24, 2018 12:22 PM, Sakari Ailus wrote: > > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: > >> Add v4l2 controls to report the pixel and MIPI link rates of each mode. > >> The camss camera subsystem needs them to set up the correct hardware > >> clocks. > >> > >> Tested on msm8016 based hardware. > >> > >> Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx> > > > > Maxime has written a number of patches against the driver that seem very > > much related; could you rebase these on his set (v2)? > > > > <URL:https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Maxime+Ripard&state=*&q=ov5640> > > I didn't know about the ongoing work in this area, so I think both this > and 3/3 are not needed. If you want, you can still pick the 1st patch in > this series, but that's just a cosmetic cleanup. That patch, too, would effectively need a rebase. I'd also suggest adding a macro that constructs the entries in the array --- much of what changes from entry to entry are fps, width, height and whether subsampling or scaling has been used. That information would likely fit nicely on a single line. The resolution names are also redundant as the size is explicitly part of the mode list variable names. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx
