On Mon, Apr 16, 2018 at 12:37:03PM -0400, Mauro Carvalho Chehab wrote: > When I started building media subsystem with the atomisp driver, > I ended by adding several hacks on their Makefiles, in order to > get rid of thousands of warnings. I felt a little guty of hiding how > broken is this driver, so I decided t remove two Makefile hacks that > affect sensors and fix the warnings. > > Yet, there's still one such hack at > drivers/staging/media/atomisp/pci/atomisp2/Makefile, with: > > # HACK! While this driver is in bad shape, don't enable several warnings > # that would be otherwise enabled with W=1 > ccflags-y += $(call cc-disable-warning, implicit-fallthrough) > ccflags-y += $(call cc-disable-warning, missing-prototypes) > ccflags-y += $(call cc-disable-warning, missing-declarations) > ccflags-y += $(call cc-disable-warning, suggest-attribute=format) > ccflags-y += $(call cc-disable-warning, unused-const-variable) > ccflags-y += $(call cc-disable-warning, unused-but-set-variable) > > Getting his of those is a big task, as there are thousands of warnings > hidden there. In order to seriously get rid of them, one should start > getting rid of the several abstraction layers at the driver and have > hardware for test. > > As I don't have any hardware to test, nor any reason why > dedicating myself to such task, I'll just leave this task for others > to do. Thanks. Feel free to add: Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> And take the patches through your tree. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
