Re: [PATCH] media: davinci: don't override the error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2018 at 07:22:19AM -0400, Mauro Carvalho Chehab wrote:
> As warned by Coverity:
> 	CID 1415211 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
> 	Assigning value -22 to ret here, but that stored value is
> 	overwritten before it can be used.
> 
> On all cases where the there's a goto 'unlock_out' or 'streamof',
> ret was filled with a non-sero value. It toesn't make sense to override
> such error code with a videobuf_streamoff() error.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>

Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux