Re: [PATCH] media: em28xx: Don't use ops->resume if NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 23, 2018 at 07:02:39AM -0400, Mauro Carvalho Chehab wrote:
> Changeset  be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD
> second tuner functionality") introduced a potential NULL pointer
> dereference, as pointed by Coverity:
> 
> CID 1434731 (#1 of 1): Dereference after null check (FORWARD_NULL)16. var_deref_op: Dereferencing null pointer ops->resume.
> 
> var_compare_op: Comparing ops->resume to null implies that ops->resume might be null.
> 1174                if (ops->resume)
> 1175                        ops->resume(dev);
> 1176                if (dev->dev_next)
> 1177                        ops->resume(dev->dev_next);
> 
> Fixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner functionality")
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>

Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux