On 04/09/18 14:15, Russell King - ARM Linux wrote: > Hi, > > This patch series adds CEC support to the DRM TDA998x driver. The > TDA998x family of devices integrate a TDA9950 CEC at a separate I2C > address from the HDMI encoder. > > Implementation of the CEC part is separate to allow independent CEC > implementations, or independent HDMI implementations (since the > TDA9950 may be a separate device.) Reviewed, looks good. Thanks! Hans > > .../devicetree/bindings/display/bridge/tda998x.txt | 3 + > drivers/gpu/drm/i2c/Kconfig | 6 + > drivers/gpu/drm/i2c/Makefile | 1 + > drivers/gpu/drm/i2c/tda9950.c | 509 +++++++++++++++++++++ > drivers/gpu/drm/i2c/tda998x_drv.c | 242 ++++++++-- > include/linux/platform_data/tda9950.h | 16 + > 6 files changed, 750 insertions(+), 27 deletions(-) > create mode 100644 drivers/gpu/drm/i2c/tda9950.c > create mode 100644 include/linux/platform_data/tda9950.h > > v3: addressed most of Hans comments in v2 > v2: updated DT property. > >