On 12/2/2009 9:12 AM, Tobias Lorenz wrote: > Hi, > > ok, understood this problem. > So, why not set this in si470x_fops_open directly after the si470x_start? > It seems more appropriate to enable the RDS interrupt after starting the radio. > OK, it makes sense. I will move it in si470x_fops_open. > Bye the way, you pointed me to a bug. Instead of always setting de-emphasis in si470x_start: > radio->registers[SYSCONFIG1] = SYSCONFIG1_DE; > This should only be done, if requested by module parameter: > radio->registers[SYSCONFIG1] = (de << 11) & SYSCONFIG1_DE; /* DE */ > Ah, That's right. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html