Jean-Francois Moine wrote: > On Sat, 28 Nov 2009 08:13:05 +0100 > Németh Márton <nm127@xxxxxxxxxxx> wrote: > >> what do you think about this patch? > > Hi Márton, > > There are many other drivers where the usb_control_msg() errors are not > tested nor propagated to higher levels. Generally, this does not matter: > the errors are signalled at the lowest level, and they seldom occur. > Thus, I don't think your patch is useful... I think that the return value of the usb_control_msg() is to be evaluated. If other drivers also not evaluating the usb_control_msg() *they* has to be fixed. The benefit would be that the userspace program can recognise error condition faster and react accordingly. For example the USB device can be unplugged any time. In this case there is no use to continue sending URBs. Otherwise the user program thinks that everything went on correctly and the user will be surprised how come that he or she unplugged a device and it is still working. Regards, Márton Németh -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
