Hi Andy, Thanks for the update. On Fri, Jan 26, 2018 at 01:58:55AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh <andy.yeh@xxxxxxxxx> > Signed-off-by: Jason Chen <jasonx.z.chen@xxxxxxxxx> > Signed-off-by: Alan Chiang <alanx.chiang@xxxxxxxxx> > --- > since v2: > -- Update the streaming function to remove SW_STANDBY in the beginning. > -- Adjust the delay time from 1ms to 12ms before set stream-on register. > since v3: > -- fix the sd.entity to make code be compiled on the mainline kernel. > since v4: > -- Enabled AG, DG, and Exposure time control correctly. This patch seems to include also DIGITAL_GAIN control support but also the removal of the VBLANK control from s_ctrl callback. Is there still an intent to support the VBLANK control? Also registers are written one octet at a time rather than two, which could lead to sensor using settings that are only half-updated (does the datasheet say this is safe?). Is there a reason for this? Seems fine otherwise to me. -- Kind regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
