[bug report] V4L/DVB(7872): mxl5005s: checkpatch.pl compliance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Steven Toth,

The patch d211017b9544: "V4L/DVB(7872): mxl5005s: checkpatch.pl
compliance" from May 1, 2008, leads to the following static checker
warning:

	drivers/media/tuners/mxl5005s.c:1817 MXL_BlockInit()
	warn: both sides of ternary the same: '1'

drivers/media/tuners/mxl5005s.c
  1812          }
  1813  
  1814          /* Charge Pump Control Dig  Ana */
  1815          status += MXL_ControlWrite(fe, RFSYN_CHP_GAIN, state->Mode ? 5 : 8);
  1816          status += MXL_ControlWrite(fe,
  1817                  RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
                                             ^^^^^^^^^^^^^^^^^^^
  1818          status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);
                                                             ^^^^^^^^^^^^^^^^^^^
What do these mean?  What are they supposed to do?

  1819  

regards,
dan carpenter



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux