Hans Verkuil wrote: > On Wednesday 25 November 2009 19:42:15 Mauro Carvalho Chehab wrote: >> Hans Verkuil wrote: >>> Hi Mauro, >>> >>> Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb for the following: >>> >>> - spec: unexpand initial spaces when generating xml sources >>> - spec: regenerated xml source files >> Hans, >> >> I'm not sure if this is the right way. The tabs are replaced by spaces there for >> some reason. I'm not a DocBook expert, but maybe this will cause some document >> messing. If not then the better is to just not expanding tabs at all. > > The reason the tabs are replaced has to do with 'non-leading' tabs, e.g. tabs that > are not at the start of the line, but for example between a statement and a comment. > Since the xml generation will replace some types or structs with hyperlinks the > following text is no longer tab-aligned. > > This is not however a problem with leading spaces: these can still safely be > converted back to tabs. > >> I think it would be easier to just prevent make rmspaces to run the script against >> *.[ch].xml. > > I think you are right. I'll make another pull request for this. Ok. FYI, I've already cherry-picked the other two patches. > My solution is OK, but it is just simpler to not run rmspaces for these files. > Definitely easier to understand as well. Agreed. Cheers, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
