Hi Akinobu,
Thanks for the patchset.
On Thu, Dec 21, 2017 at 01:33:33AM +0900, Akinobu Mita wrote:
> The mt9m111 driver requires clocks property for the master clock to the
> sensor, but there is no description for that. This adds it.
>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> index ed5a334..ffb57d1 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> @@ -6,6 +6,8 @@ interface.
>
> Required Properties:
> - compatible: value should be "micron,mt9m111"
> +- clocks: reference to the master clock.
> +- clock-names: should be "mclk".
s/should/shall/
?
The subject could begin with "media: " but not with "meida: ". Mauro's
scripts will add it so you may equally well omit it altogether.
>
> For further reading on port node refer to
> Documentation/devicetree/bindings/media/video-interfaces.txt.
> @@ -16,6 +18,8 @@ Example:
> mt9m111@5d {
> compatible = "micron,mt9m111";
> reg = <0x5d>;
> + clocks = <&mclk>;
> + clock-names = "mclk";
>
> remote = <&pxa_camera>;
> port {
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@xxxxxx
