On Tue, Nov 24, 2009 at 6:39 PM, Andy Walls <awalls@xxxxxxxxx> wrote: > BTW, I did a quick skim of your cx18-alsa stuff. I noticed two things: > > 1. A memory leak in an error path: > > http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2/rev/cb267593943f#l85 > > > 2. Technically open_id should probably be changed to an atomic type and > atomic_inc() used: > > http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2/rev/cb267593943f#l80 > > Under normal use it will likely never matter though, but perhaps someone > could use it as a possible exploit. > > > > I'll try and give the code a good review and test sometime this weekend. > I just wanted to let you know about those minor bugs before I forgot. Thanks for taking the time to review. I will make both of those changes early next week. Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
