On Mon, Dec 18, 2017 at 12:11:13PM -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 13 Oct 2017 15:24:34 +0200
> Hans Verkuil <hverkuil@xxxxxxxxx> escreveu:
>
> > > ---
> > > include/media/v4l2-common.h | 14 +++++---------
> > > 1 file changed, 5 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> > > @@ -238,11 +239,6 @@ struct v4l2_priv_tun_config {
> > >
> > > #define VIDIOC_INT_RESET _IOW ('d', 102, u32)
>
> >
> > Regarding this one: I *think* (long time ago) that the main reason for this
> > was to reset a locked up IR blaster. I wonder if this is still needed after
> > Sean's rework of this. Once that's all done and merged this would probably
> > merit another look to see if it can be removed.
>
> Sean,
>
> Could you please double-check if this is still required on RC?
The ioctl can also reset the digitizer in ivtv, I don't know anything
about that.
As far the IR receiver/blaster is concerned:
This ioctl does exactly as it says and it works. There are a few ways
that the zilog microcontroller can be crashed, but I don't know of any
that exist in the current code base.
I seem to recall that the microcontroller could get stuck due particular
i2c states, which was fixed with patches to ivtv-i2c.c. That does not mean
there aren't any others though.
What would be nicer if the ir driver got no response, it would reset it
automatically. I'm not sure how to wire up ir-kbd-i2c with the ir reset
function of ivtv and cx18 though.
Then again with no known use cases it seems superfluous. How about removing
the ioctl and then hooking up the IR driver to the reset, should it be
necessary?
Sean
