On 09/27/17 23:46, Mauro Carvalho Chehab wrote:
> This struct is not used anymore. Get rid of it and update
> the documentation about what should still be converted.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
> include/media/v4l2-common.h | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> index aac8b7b6e691..7dbecbe3009c 100644
> --- a/include/media/v4l2-common.h
> +++ b/include/media/v4l2-common.h
> @@ -224,10 +224,11 @@ void v4l2_spi_subdev_init(struct v4l2_subdev *sd, struct spi_device *spi,
>
> /* ------------------------------------------------------------------------- */
>
> -/* Note: these remaining ioctls/structs should be removed as well, but they are
> - still used in tuner-simple.c (TUNER_SET_CONFIG), cx18/ivtv (RESET) and
> - v4l2-int-device.h (v4l2_routing). To remove these ioctls some more cleanup
> - is needed in those modules. */
> +/*
> + * FIXME: these remaining ioctls/structs should be removed as well, but they
> + * are still used in tuner-simple.c (TUNER_SET_CONFIG) and cx18/ivtv (RESET).
> + * To remove these ioctls some more cleanup is needed in those modules.
> + */
>
> /* s_config */
> struct v4l2_priv_tun_config {
> @@ -238,11 +239,6 @@ struct v4l2_priv_tun_config {
>
> #define VIDIOC_INT_RESET _IOW ('d', 102, u32)
Regarding this one: I *think* (long time ago) that the main reason for this
was to reset a locked up IR blaster. I wonder if this is still needed after
Sean's rework of this. Once that's all done and merged this would probably
merit another look to see if it can be removed.
Regards,
Hans
>
> -struct v4l2_routing {
> - u32 input;
> - u32 output;
> -};
> -
> /* ------------------------------------------------------------------------- */
>
> /* Miscellaneous helper functions */
>
