On 03/12/17 14:11, Soeren Moch wrote:
On 03.12.2017 11:57, Jemma Denson wrote:
On 02/12/17 23:59, Soeren Moch wrote:
All the entries in the TODO file are not specific for saa716x_ff.
Ah, it's been a few months since I looked at that. I think some of the
things listed I had already identified as problems - checkpatch
especially,
Finding checkpatch problems is easy...
Indeed they are. They still take some time to go though.
Hence my comment about finding a maintainer - I had assumed if the
immediate result didn't support your card you probably wouldn't be
willing
to do that.
What I'm trying to do here is get *something* merged, and then once
that work is done any interested parties can add to it. Or at the very
least if some patches are left OOT the constant workload required to
keep that up to date should be reduced significantly because they'll be
far less to look after.
Why not merge the driver as-is? The community would get support for
several cards, easy access to the code without the need for separate git
repositories or dkms packages, and a maintainer that understands the
hardware and driver code.
The whole purpose of driver development is bringing support for existing
hardware to available user applications, preferably with existing APIs.
And exactly that is in this pull request.
In the whole discussion I cannot find a single reason, how merging this
driver would violate the linux development principles.
That's not really one for me to answer, but Mauro has raised objections
so it can't be merged as is. I'm just trying to find a way forward that
avoids this getting stuck for another few years.
One of the problems though is choosing which fork to use. I *think* there
are 2 - the one you've got which is the original powARman branch and the
one I would be using is the CrazyCat / Luis / TBS line. There are
going to be
some differences but hopefully that's all frontend support based and
one cut
down to a single frontend would end up a good base to add the rest back
in.
I think my repository represents the main development branch, just
maintained by different people (adding Manu, Andreas, Oliver, in case
they want to object). The CrazyCat repo is not a fork (including
history), it is just a snapshot of the driver plus several patches.
Well I know of several patches I've made to that repo that haven't
made it back to the "main" branch, so whilst maybe not a fork in
the traditional sense it certainly is functioning like one.
As I said, I'm just trying to get *something* merged. I can base a
ff-stripped patch on the powarman branch instead but it does represent
more work for me as I need to work out what else might be missing to
support the only card I have for testing this with. It might end up being
easy but I don't know that yet.
Let's get something happening here rather than just trying to argue
with the maintainers. There's absolutely nothing stopping further patches
being sent in later on once the chipset driver is merged.
Jemma.
