Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> writes: > On 26/09/2017 15:02, Måns Rullgård wrote: > >> I could continue nit-picking, but I think this is good enough. >> Thanks for being patient. >> >> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx> > > Smirk. > > If you feel like making a final round of changes on top of this patch, > then go for it. It's your code, after all. > > (Too bad there is no devm variant of clk_prepare_enable.) > > Does it make sense to submit a keymap for the Sigma remote control > used with Vantage boards? And define that as the default keymap? Maybe. The real product I have with a tango3 chip uses a remote control that is quite similar the Sigma one. Having something that works out of the box with the dev board is also nice. -- Måns Rullgård