Re: [PATCH v5 2/2] media: rc: Add driver for tango HW IR decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> writes:

> * Delete two writes clearing interrupts in probe (cleared is reset value)

Noooooo.  You can't know what state the hardware is in when this code
runs.  Drivers should *always* fully initialise the hardware to a known
state.  It is especially important to clear any pending interrupts since
otherwise they'll fire the moment the irq is unmasked and can cause all
sorts of mayhem.

-- 
Måns Rullgård



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux