On Mon, Sep 25, 2017 at 11:41:02AM +0200, Hans Verkuil wrote: > If you have a control handler that does not contain any controls, then > currently calling VIDIOC_G/S/TRY_EXT_CTRLS with count == 0 will return > -EINVAL in the class_check() function. > > This is not correct, there is no reason why this should return an error. > > The purpose of setting count to 0 is to test if the ioctl can mix controls > from different control classes. And this is possible. The fact that there > are not actually any controls defined is another matter that is unrelated > to this test. > > This caused v4l2-compliance to fail, so that is fixed with this patch applied. > > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > Reported-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > Tested-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> -- Sakari Ailus e-mail: sakari.ailus@xxxxxx
