>> @@ -1913,11 +1908,12 @@ static int usbvision_set_compress_params(struct usb_usbvision *usbvision) >> USB_DIR_OUT | USB_TYPE_VENDOR | >> USB_RECIP_ENDPOINT, 0, >> (__u16) USBVISION_PCM_THR1, value, 6, HZ); >> + if (rc < 0) >> +report_failure: >> + dev_err(&usbvision->dev->dev, >> + "%s: ERROR=%d. USBVISION stopped - reconnect or reload driver.\n", >> + __func__, rc); > > You've been asked several times not to write code like this. This suggestion occurred a few times. Do you prefer to move this place to the end together with a duplicated statement “return rc;”? > You do it later in the patch series as well. To which update step do you refer here? Regards, Markus
