On Thu, Aug 24, 2017 at 08:47:54AM +0200, Hans Verkuil wrote: > On 08/24/2017 02:07 AM, Jasmin J. wrote: > > Hi! > > > > Just some notes on that patch. > > > > I have *not* tested it due to the lack of an ir remote control. So someone > > needs to test this on an <= 4.9 Kernel, if the ir core is still working as > > expected. > > > > Even if I fixed that in media_build, it may be better to apply this code change > > in media_tree. This because the involved variables are all of type ktime_t and > > there are accessor and converter functions available for that type, which > > should have been used by the original author of 86fe1ac0d and 48b2de197 in my > > opinion. > > Sean, > > I agree with Jasmin here. I noticed the same errors in the daily build and it > is really caused by not using the correct functions. I just didn't have the > time to follow up on it. > > Can you take a look at Jasmin's patch and, if OK, make a pull request for > it? I hadn't taken media_build into account when I wrote this, so yes I'll have a look and create a pull request. Sean
