Re: [PATCH] [media_build] rc: Fix ktime erros in rc_ir_raw.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/24/2017 02:07 AM, Jasmin J. wrote:
> Hi!
> 
> Just some notes on that patch.
> 
> I have *not* tested it due to the lack of an ir remote control. So someone
> needs to test this on an <= 4.9 Kernel, if the ir core is still working as
> expected.
> 
> Even if I fixed that in media_build, it may be better to apply this code change
> in media_tree. This because the involved variables are all of type ktime_t and
> there are accessor and converter functions available for that type, which
> should have been used by the original author of 86fe1ac0d and 48b2de197 in my
> opinion.

Sean,

I agree with Jasmin here. I noticed the same errors in the daily build and it
is really caused by not using the correct functions. I just didn't have the
time to follow up on it.

Can you take a look at Jasmin's patch and, if OK, make a pull request for
it?

Regards,

	Hans



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux