Hi Mauro,
This reverts the change from pointer comparison to full OF node path
comparison. As per commit message:
The commit was flawed in that if the device_node pointers are different,
then in fact a different device is present and the device node could be
different in ways other than full_name.
As Frank Rowand explained:
"When an overlay (1) is removed, all uses and references to the nodes and
properties in that overlay are no longer valid. Any driver that uses any
information from the overlay _must_ stop using any data from the overlay.
Any driver that is bound to a new node in the overlay _must_ unbind. Any
driver that became bound to a pre-existing node that was modified by the
overlay (became bound after the overlay was applied) _must_ adjust itself
to account for any changes to that node when the overlay is removed. One
way to do this is to unbind when notified that the overlay is about to
be removed, then to re-bind after the overlay is completely removed.
If an overlay (2) is subsequently applied, a node with the same
full_name as from overlay (1) may exist. There is no guarantee
that overlay (1) and overlay (2) are the same overlay, even if
that node has the same full_name in both cases."
Also, there's not sufficient overlay support in mainline to actually
remove and re-apply an overlay to hit this condition as overlays can
only be applied from in kernel APIs.
Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Cc: Javi Merino <javi.merino@xxxxxxxxxx>
Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Cc: Sylwester Nawrocki <s.nawrocki@xxxxxxxxxxx>
Cc: Frank Rowand <frowand.list@xxxxxxxxx>
Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
Acked-by: Javi Merino <javi.merino@xxxxxxxxxx>
Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Please pull.
The following changes since commit 0659445f47586b128613e011eae9f24b07ebe838:
media: staging: atomisp: sh_css_calloc shall return a pointer to the allocated space (2017-08-09 10:49:36 -0400)
are available in the git repository at:
ssh://linuxtv.org/git/sailus/media_tree.git fwnode-fix
for you to fetch changes up to 219ebbde1b134f9ae357b6e45c215f71de6f48d3:
Revert "[media] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay" (2017-08-10 10:40:51 +0300)
----------------------------------------------------------------
Rob Herring (1):
Revert "[media] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay"
drivers/media/v4l2-core/v4l2-async.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
