On Thu, Aug 10, 2017 at 04:00:05PM +0900, Tomasz Figa wrote: > Hi Chiranjeevi, > > On Thu, Aug 10, 2017 at 6:59 AM, Chiranjeevi Rapolu > <chiranjeevi.rapolu@xxxxxxxxx> wrote: > > Previously, pixel-rate/(pixels-per-line * lines-per-frame) was > > yielding incorrect frame timing for the user. > > > > OV sensor is using internal timing and this requires > > conversion (internal timing -> PPL) for correct HBLANK calculation. > > > > Now, change pixels-per-line domain from internal sensor clock to > > pixels domain. Set HBLANK read-only because fixed PPL is used for all > > resolutions. And, use more accurate link-frequency 422.4MHz instead of > > rounding down to 420MHz. > > > > Signed-off-by: Chiranjeevi Rapolu <chiranjeevi.rapolu@xxxxxxxxx> > > --- > > Changes in v2: > > - Change subject to reflect frame timing info. > > - Change OV5670_DEF_PPL so that it doesn't convey a register default > > value. And, add more comments to it. > > drivers/media/i2c/ov5670.c | 45 +++++++++++++++++++++++---------------------- > > 1 file changed, 23 insertions(+), 22 deletions(-) > > Okay, the numbers in this version finally make sense. Thanks for > figuring this out. > > Reviewed-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> Thanks, applied! -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
