On Tue, 10 Nov 2009, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 05 November 2009 18:07:09 Karicheri, Muralidharan wrote: > > Guennadi, > > > > >> in the v4l2_queryctrl struct. > > > > > >I think, this is unrelated. Muralidharan just complained about the > > >soc_camera_find_qctrl() function being used in client subdev drivers, that > > >were to be converted to v4l2-subdev, specifically, in mt9t031.c. And I > > >just explained, that that's just a pretty trivial library function, that > > >does not introduce any restrictions on how that subdev driver can be used > > >in non-soc-camera configurations, apart from the need to build and load > > >the soc-camera module. In other words, any v4l2-device bridge driver > > >should be able to communicate with such a subdev driver, calling that > > >function. > > > > If soc_camera_find_qctrl() is such a generic function, why don't you > > move it to v4l2-common.c so that other platforms doesn't have to build > > SOC camera sub system to use this function? Your statement reinforce > > this. > > I second this. Hans is working on a controls framework that should (hopefully > :-)) make drivers simpler by handling common tasks in the v4l core. Well, if you look at the function itself and at how it got replaced in this version of the patch by O(1) operations, you'll, probably, agree, that avoiding that function where possible is better than making it generic. But if there are any legitimate users for it - sure, can make it generic too. > Do you have any plan to work on the bus hardware configuration API ? When that > will be available the mt9t031 driver could be made completely soc-camera-free. I'd love to first push the proposed image-bus upstream. Even with just that many drivers can already be re-used. As for bus configuration, I thought there were enough people working on it already:-) If not, maybe I could have a look at it, but we better reach some agreement on that beforehand to avoid duplicating the effort. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
