Hi Guennadi, On Thursday 05 November 2009 18:07:09 Karicheri, Muralidharan wrote: > Guennadi, > > >> in the v4l2_queryctrl struct. > > > >I think, this is unrelated. Muralidharan just complained about the > >soc_camera_find_qctrl() function being used in client subdev drivers, that > >were to be converted to v4l2-subdev, specifically, in mt9t031.c. And I > >just explained, that that's just a pretty trivial library function, that > >does not introduce any restrictions on how that subdev driver can be used > >in non-soc-camera configurations, apart from the need to build and load > >the soc-camera module. In other words, any v4l2-device bridge driver > >should be able to communicate with such a subdev driver, calling that > >function. > > If soc_camera_find_qctrl() is such a generic function, why don't you > move it to v4l2-common.c so that other platforms doesn't have to build > SOC camera sub system to use this function? Your statement reinforce > this. I second this. Hans is working on a controls framework that should (hopefully :-)) make drivers simpler by handling common tasks in the v4l core. Do you have any plan to work on the bus hardware configuration API ? When that will be available the mt9t031 driver could be made completely soc-camera-free. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html