Hi Niklas, On Wed, Jul 19, 2017 at 12:49:42PM +0200, Niklas Söderlund wrote: > Hi, > > I know Sakari have posted a series '[RFC 00/19] Async sub-notifiers and > how to use them' which address similar problems as this series. This is > not intended to compete whit his work and Sakari includes one of my v3 > patches in his series. Never the less I post this updated series since > it fixes some issues in my v3 implementation and contains some other > fixes for the v4l2-async framework which are not addressed in Sakaris > patches. I think the correct solution to the problems we both try to fix > is a mix of our two series, would you agree Sakari? > > This series enables incremental async find and bind of subdevices, > please se patch 4/4 for a more detailed description. This is a rewrite > of the feature since v3, see changelog in this cover letter for the > differences to v3. The two primary reasons for a new implementation > where: > > 1. Hans expressed an interest having the async complete() callbacks to > happen only once all notifiers in the pipeline where complete. To do > this a stronger connection between the notifiers where needed, hence > the subnotifier is now embedded in struct v4l2_subdev. > > Whit this change it is possible to check all notifiers in a pipeline > is complete before calling any of them. > > 2. There where concerns that the v3 solution was a bit to complex and > hard to refactor in the future if other issues in the v4l2-async > framework where to be addressed. By hiding the notifier in the struct > v4l2_subdev and adding a new function to set that structure the > interface towards drivers are minimized while everything else happens > in the v4l2-async framework. This leaves the interface in a good > position for possible changes in v4l2-async. > > This is tested on Renesas H3 and M3-W together with the Renesas CSI-2 > and VIN Gen3 driver (posted separately). It is based on top of the media-tree. Thanks for the new iteration, you can add my Tested-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> On the cadence CSI2 RX driver I sent earlier. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
