Re: [PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19/07/17 13:54, Niklas Söderlund wrote:
> Hi Hans,
> 
> Thanks for your feedback.
> 
> On 2017-07-19 13:02:14 +0200, Hans Verkuil wrote:
>> On 19/07/17 12:49, Niklas Söderlund wrote:
>>> * Changes since v4
>>> - Add patch which aborts v4l2_async_notifier_unregister() if the memory 
>>>   allocation for the device cache fails instead of trying to do as much 
>>>   as possible but still leave the system in a semi good state.
>>
>> Since you are working with this code I would very much appreciate it if you
>> can make another patch that adds comments to this reprobing stuff, including
>> why device_reprobe() cannot be used here.
> 
> I could do that.
> 
> I think it makes most sens to break out patch 1-3 plus this new patch to 
> a new series 'v4l2-async: clean up v4l2_async_notifier_unregister()' or 
> something similar and post separate from the subnotifer work as me and 
> Sakari are still bashing out a common solution to that.
> 
> Do this make sens to you or do you wish for me to keep these patches 
> together in this series?

That makes sense. It's good to have those fixes in.

Regards,

	Hans



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux