On Fri, Jul 7, 2017 at 11:15 AM, Pavel Machek <pavel@xxxxxx> wrote: > On Fri 2017-07-07 08:59:28, Rob Herring wrote: >> On Sun, Jul 02, 2017 at 12:06:13PM +0100, Sean Young wrote: >> > This is new driver which uses pwm, so it is more power-efficient >> > than the bit banging gpio-ir-tx driver. >> > >> > Signed-off-by: Sean Young <sean@xxxxxxxx> >> > --- >> > .../devicetree/bindings/leds/irled/pwm-ir-tx.txt | 13 ++ >> >> Please make this a separate patch. > > Come on... The driver is trivial, and you even quoted the binding > below. Saying "Acked-by:" would not have been that much additional > work... True, and I don't always ask for it especially when there is no other comment. However, the gpio-ir-tx patch needs other changes anyway. Rob