On Fri 2017-07-07 08:59:28, Rob Herring wrote:
> On Sun, Jul 02, 2017 at 12:06:13PM +0100, Sean Young wrote:
> > This is new driver which uses pwm, so it is more power-efficient
> > than the bit banging gpio-ir-tx driver.
> >
> > Signed-off-by: Sean Young <sean@xxxxxxxx>
> > ---
> > .../devicetree/bindings/leds/irled/pwm-ir-tx.txt | 13 ++
>
> Please make this a separate patch.
Come on... The driver is trivial, and you even quoted the binding
below. Saying "Acked-by:" would not have been that much additional
work...
Thanks,
Pavel
> > drivers/media/rc/Kconfig | 12 ++
> > drivers/media/rc/Makefile | 1 +
> > drivers/media/rc/pwm-ir-tx.c | 165 +++++++++++++++++++++
> > 4 files changed, 191 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.txt
> > create mode 100644 drivers/media/rc/pwm-ir-tx.c
> >
> > diff --git a/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.txt b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.txt
> > new file mode 100644
> > index 0000000..6887a71
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/irled/pwm-ir-tx.txt
> > @@ -0,0 +1,13 @@
> > +Device tree bindings for IR LED connected through pwm pin which is used as
> > +IR transmitter.
> > +
> > +Required properties:
> > +- compatible: should be "pwm-ir-tx".
> > +- pwms : PWM property to point to the PWM device (phandle)/port (id) and to
> > + specify the period time to be used: <&phandle id period_ns>;
> > +
> > +Example:
> > + irled {
> > + compatible = "pwm-ir-tx";
> > + pwms = <&pwm0 0 10000000>;
> > + };
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
