Am Wed, 21 Jun 2017 22:20:35 +0300 schrieb Antti Palosaari <crope@xxxxxx>: > On 06/21/2017 08:20 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 21 Jun 2017 19:14:40 +0200 > > Daniel Scheller <d.scheller.oss@xxxxxxxxx> escreveu: > > > >> I intentionally left this in for the pr_info used in module_init_ddbridge(). If you prefer, we can ofc probably also leave this as printk like > >> > >> printk(KERN_INFO KBUILD_MODNAME ": Digital..."); > > > > Ah, OK! > > But why you even need it? Probe should be first place you need to print > something and there is always proper device pointer. This will be printed whenever the module is loaded. When in ddb_probe, you won't notice ever if the module is loaded for whatever reason if no DD card is there, or a card is present which isn't supported, and printed multiple times if you have more than one supported card (imagine a CTv6 plus module, and a CI Bridge, which gets common these days). Let's keep it as it is, please. Regards, Daniel Scheller -- https://github.com/herrnst
