Hi Sakari, On Mon, 2017-05-29 at 23:38 +0300, Sakari Ailus wrote: [...] > > diff --git a/Documentation/media/uapi/mediactl/media-types.rst b/Documentation/media/uapi/mediactl/media-types.rst > > index 2a5164aea2b40..1d15542f447c1 100644 > > --- a/Documentation/media/uapi/mediactl/media-types.rst > > +++ b/Documentation/media/uapi/mediactl/media-types.rst > > @@ -299,6 +299,28 @@ Types and flags used to represent the media graph elements > > received on its sink pad and outputs the statistics data on > > its source pad. > > > > + - .. row 29 > > + > > + .. _MEDIA-ENT-F-VID-MUX: > > + > > + - ``MEDIA_ENT_F_VID_MUX`` > > + > > + - Video multiplexer. An entity capable of multiplexing must have at > > + least two sink pads and one source pad, and must pass the video > > + frame(s) received from the active sink pad to the source pad. Video > > + frame(s) from the inactive sink pads are discarded. > > I don't think the last sentence is needed, I'd drop it as redundant. Up to > you. Thanks, I'll drop this sentence ... > > + > > + - .. row 30 > > + > > + .. _MEDIA-ENT-F-VID-IF-BRIDGE: > > + > > + - ``MEDIA_ENT_F_VID_IF_BRIDGE`` > > + > > + - Video interface bridge. A video interface bridge entity must have at > > + least one sink pad and one source pad. It receives video frames on > > It's not clear whether there must be at least one source pad or one source > pad. How about either: > > "must have at least one sink pad and at least one source pad" or ... and change this to specify "at least one source pad". > "must have at least one sink pad and exactly one source pad"? > > With this considered, > > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> [...] regards Philipp
