> > > + if (ret) > > > + dev_err(dev, "%s I2C failure: %d", __func__, > > > + ret); > > > > I think we should just return an error code here and fail the suspend. > > The result from an error here is that the user would hear an audible click. > I don't think it's worth failing system suspend. :-) > > But as no action is taken based on the error code, there could be quite a few of > these messages. How about dev_err_once()? For resume I might use > dev_err_ratelimited(). > Ack (addressed with v5 of this patch)
