Hi Sakari, Sylwester, > > > > You're right, sorry. I'd expect such things to be better covered in > > the API documentation. Probably pm_runtime_put_noidle() is a better > > Well, the documentation tells what the function does. It'd be good if it pointed > that the usage count needs to be decremented if the function fails. > > I guess the reason is that it's just a synchronous variant of pm_runtime_get(), > which could not handle the error anyway. > > > match for just decreasing usage_count. Now many drivers appear to not > > be balancing usage_count when when pm_runtime_get_sync() fails. > > Ah, quite a few drivers seem to be using pm_runtime_put_noidle() which seems > to be the correct thing to do as the device won't be on then anyway. > Ack > -- > Regards, > > Sakari Ailus > e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
