Hello Daniel, Eric, On Mon, Monday, May 8, 2017 9:29 PM +0200, Daniel Vetter wrote: > -----Original Message----- > From: Daniel Vetter [mailto:daniel.vetter@xxxxxxxx] On Behalf Of Daniel > Vetter > Sent: 8 mai 2017 21:30 > To: Eric Anholt <eric@xxxxxxxxxx> > Cc: Gheorghe, Alexandru <Alexandru_Gheorghe@xxxxxxxxxx>; > laurent.pinchart@xxxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; > dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-media@xxxxxxxxxxxxxxx; geert@linux- > m68k.org; sergei.shtylyov@xxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH v2 0/2] rcar-du, vsp1: rcar-gen3: Add support for > colorkey alpha blending > > On Mon, May 08, 2017 at 09:33:37AM -0700, Eric Anholt wrote: > > Alexandru Gheorghe <Alexandru_Gheorghe@xxxxxxxxxx> writes: > > > > > Currently, rcar-du supports colorkeying only for rcar-gen2 and it > > > uses some hw capability of the display unit(DU) which is not available on > gen3. > > > In order to implement colorkeying for gen3 we need to use the > > > colorkey capability of the VSPD, hence the need to change both > > > drivers rcar-du and vsp1. > > > > > > This patchset had been developed and tested on top of > > > v4.9/rcar-3.5.1 from > > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git > > > > A few questions: > > > > Are other drivers interested in supporting this property? VC4 has the > > 24-bit RGB colorkey, but I don't see YCBCR support. Should it be > > documented in a generic location? As far as I identified armada, i815, nouveau, rcar-du, vmwgfx drivers have this notion of colorkey. There could be other HW which don't have this implemented yet. > > > > Does your colorkey end up forcing alpha to 1 for the plane when it's > > not matched? I think this behavior is HW dependent, on R-CAR Gen3, the alpha for pixel that don't match is not touch. > > I think generic color-key for plane compositioning would be nice, but I'm not > sure that's possible due to differences in how the key works. I'm thinking of starting from the drivers that do have this property and see if there is any common ground for a generic color-key property/ies > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Alex Gheorghe
