On Mon, May 08, 2017 at 09:33:37AM -0700, Eric Anholt wrote: > Alexandru Gheorghe <Alexandru_Gheorghe@xxxxxxxxxx> writes: > > > Currently, rcar-du supports colorkeying only for rcar-gen2 and it uses > > some hw capability of the display unit(DU) which is not available on gen3. > > In order to implement colorkeying for gen3 we need to use the colorkey > > capability of the VSPD, hence the need to change both drivers rcar-du and > > vsp1. > > > > This patchset had been developed and tested on top of v4.9/rcar-3.5.1 from > > git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git > > A few questions: > > Are other drivers interested in supporting this property? VC4 has the > 24-bit RGB colorkey, but I don't see YCBCR support. Should it be > documented in a generic location? > > Does your colorkey end up forcing alpha to 1 for the plane when it's not > matched? I think generic color-key for plane compositioning would be nice, but I'm not sure that's possible due to differences in how the key works. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
