Hi Laurent, On Fri, Apr 07, 2017 at 01:01:29PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 06 Apr 2017 16:12:08 Sakari Ailus wrote: > > media/drv-intf/soc_mediabus.h does depend on struct v4l2_mbus_config which > > is defined in media/v4l2-mediabus.h. Include it. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Was this provided indirectly before, through v4l2-of.h perhaps ? If so, > shouldn't this patch be moved before 5/8 ? Apart from that, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> I tried compiling with and without this patch and see no difference. I could miss something but the more likely case is that the reason why I wrote this patch has ceased to exist. I'll drop it from the set, at least for now. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx